Re: [PATCH v3] t6030 (bisect): work around Mac OS X "ls"

From: Jonathan Nieder <jrnieder@uchicago.edu>
Date: Jul 24, 2008, 18:16 UTC
Message-ID: <Pine.GSO.4.62.0807241307020.17634@harper.uchicago.edu>
In-Reply-To: <Pine.GSO.4.62.0807241233190.16518@harper.uchicago.edu>

Jonathan Nieder wrote:

> -	test_must_fail ls .git/BISECT_* &&
> +	case $(echo .git/BISECT_*) in *\*) ;; *) false ;; esac &&

Actually, if we want to go that route, I prefer the version Dscho gave. So please ignore my patch v3; I'd rather people choose between Christian's and Dscho's suggestions.

Personally, without knowing how much time avoiding the ls saves, I
am not sure which is best.  Certainly the version with "ls" is clearer,
which is most important; but if the time savings (of avoiding such
constructs generally) are significant, then that is very much worthwhile
- a faster test suite can be run more often.

Jonathan