From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 24 Jul 2008 17:44:12 GMT
Subject: Re: [PATCH v2] t6030 (bisect): work around Mac OS X "ls"
Message-ID: <alpine.DEB.1.00.0807241842030.8986@racer>
In-Reply-To: <20080724165434.GA26660@glandium.org>

Hi,

On Thu, 24 Jul 2008, Mike Hommey wrote:

> On Thu, Jul 24, 2008 at 02:43:51AM -0500, Jonathan Nieder wrote:
>
> > Mike Hommey wrote:
> > 
> > > On Thu, Jul 24, 2008 at 07:57:26AM +0200, Christian Couder wrote:
> > >
> > >> +	test -z "$(ls .git/BISECT_*)" &&
> > > 
> > > That is still a useless use of ls ;)
> > 
> > It is much better than what I wrote, at least.
> 
> But could also be written with echo instead of ls.

Sure, but then it looks uglier:

		test ".git/BISECT_*" = "$(echo .git/BISECT_*)" &&

and it is much easier to hide a typo there.

And now the big question: is it performance critical?  Or is obvious 
correctness the highest goal here?

Hth,
Dscho