git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t6030 (bisect): work around Mac OS X "ls"

From
Jonathan Nieder <jrnieder@uchicago.edu>
Date
Jul 24, 2008, 01:37 UTC
Message-ID
<Pine.GSO.4.62.0807232014030.14945@harper.uchicago.edu>

t6030-bisect-porcelain.sh relies on "ls" exiting with nonzero status when asked to list nonexistent files. Unfortunately, /bin/ls on Mac OS X 10.3 exits with exit code 0. So use "echo <shell glob pattern>" and grep instead.

Signed-off-by: Jonathan Nieder <jrnieder@uchicago.edu>
---
	With this change, all the non-git-svn tests pass on my machine.
	I think the fix is portable but I do not have the experience to
	be sure.  So I would be happier if someone looks it over.
 t/t6030-bisect-porcelain.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh
index 0626544..d19fc1c 100755
--- a/t/t6030-bisect-porcelain.sh
+++ b/t/t6030-bisect-porcelain.sh
@@ -76,7 +76,7 @@ test_expect_success 'bisect fails if given any junk instead of revs' '
 	test_must_fail git bisect start foo $HASH1 -- &&
 	test_must_fail git bisect start $HASH4 $HASH1 bar -- &&
 	test -z "$(git for-each-ref "refs/bisect/*")" &&
-	test_must_fail ls .git/BISECT_* &&
+	echo .git/BISECT_* | test_must_fail grep BISECT_[^*] &&
 	git bisect start &&
 	test_must_fail git bisect good foo $HASH1 &&
 	test_must_fail git bisect good $HASH1 bar &&
-- 
1.5.6.3.549.g8ca11
Next: Christian Couder
Message 1 of 12 in “t6030 (bisect): work around Mac OS X "ls"”
  1. t6030 (bisect): work around Mac OS X "ls"Jonathan Nieder, Jul 24, 2008
  2. Christian CouderJul 24, 2008
  3. Mike HommeyJul 24, 2008
  4. t6030 (bisect): work around Mac OS X "ls"Jonathan Nieder, Jul 24, 2008
  5. Mike HommeyJul 24, 2008
  6. Johannes SchindelinJul 24, 2008
  7. t6030 (bisect): work around Mac OS X "ls"Jonathan Nieder, Jul 24, 2008
  8. Jonathan NiederJul 24, 2008
  9. Christian CouderJul 27, 2008
  10. Christian CouderJul 27, 2008
  11. t6030 (bisect): work around Mac OS X "ls"Jonathan Nieder, Jul 27, 2008
  12. Christian CouderJul 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.