git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] t6030 (bisect): work around Mac OS X "ls"

From
Jonathan Nieder <jrnieder@uchicago.edu>
Date
Jul 27, 2008, 04:53 UTC
Message-ID
<Pine.GSO.4.62.0807262343510.426@harper.uchicago.edu>
In-Reply-To
<200807270604.16581.chriscool@tuxfamily.org>

t6030-bisect-porcelain.sh relies on "ls" exiting with nonzero status when asked to list nonexistent files. Unfortunately, /bin/ls on Mac OS X 10.3 exits with exit code 0. So look at its output instead.

Signed-off-by: Jonathan Nieder <jrnieder@uchicago.edu>
Acked-by: Christian Couder <chriscool@tuxfamily.org>
---
On Sun, 27 Jul 2008, Christian Couder wrote:
> It seems that there is a problem with the message itself though. When I "git 
> am" it, I get:
> 
> fatal: cannot convert from x-unknown to utf-8
Hmm, not sure what happened.  Maybe resending it will work...
 t/t6030-bisect-porcelain.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh
index 0626544..244fda6 100755
--- a/t/t6030-bisect-porcelain.sh
+++ b/t/t6030-bisect-porcelain.sh
@@ -76,7 +76,7 @@ test_expect_success 'bisect fails if given any junk instead of revs' '
 	test_must_fail git bisect start foo $HASH1 -- &&
 	test_must_fail git bisect start $HASH4 $HASH1 bar -- &&
 	test -z "$(git for-each-ref "refs/bisect/*")" &&
-	test_must_fail ls .git/BISECT_* &&
+	test -z "$(ls .git/BISECT_* 2>/dev/null)" &&
 	git bisect start &&
 	test_must_fail git bisect good foo $HASH1 &&
 	test_must_fail git bisect good $HASH1 bar &&
-- 
1.5.5.1.328.gbfcc6
Previous: Christian CouderNext: Christian Couder
Message 11 of 12 in “t6030 (bisect): work around Mac OS X "ls"”
  1. t6030 (bisect): work around Mac OS X "ls"Jonathan Nieder, Jul 24, 2008
  2. Christian CouderJul 24, 2008
  3. Mike HommeyJul 24, 2008
  4. t6030 (bisect): work around Mac OS X "ls"Jonathan Nieder, Jul 24, 2008
  5. Mike HommeyJul 24, 2008
  6. Johannes SchindelinJul 24, 2008
  7. t6030 (bisect): work around Mac OS X "ls"Jonathan Nieder, Jul 24, 2008
  8. Jonathan NiederJul 24, 2008
  9. Christian CouderJul 27, 2008
  10. Christian CouderJul 27, 2008
  11. t6030 (bisect): work around Mac OS X "ls"Jonathan Nieder, Jul 27, 2008
  12. Christian CouderJul 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.