Re: [PATCH] Respect crlf attribute even if core.autocrlf has not been set

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 24, 2008, 17:14 UTC
Message-ID: <alpine.DEB.1.00.0807241811580.8986@racer>
In-Reply-To: <20080724165335.GW2925@dpotapov.dyndns.org>

Hi,

On Thu, 24 Jul 2008, Dmitry Potapov wrote:

Show 13 quoted lines

> If you do not have CRLF then there will be no conversion, so you pay 
> only the price of check. The relative cost of that check obviously 
> depends on what other operations are. I believe that the worst case for 
> this check will be when there is no other operations, just re-reading 
> files, so I did:
> 
> # touch all files to force git re-read them...
> git ls-files | xargs touch
> time git status
> 
> Here is the average based on 3 attempts:
> 0.232s with autocrlf=false
> 0.265s with autocrlf=input (14% increase)

And you tested... on git.git?  One of the smallest serious Git users?

If you want to come close to the hard cases (that you would punish with setting autocrlf = input, not yourself of course), test _at least_ the Linux kernel.

To come closer you should test on OpenOffice.org or KDE.

Hth, Dscho