Re: [PATCH] Respect crlf attribute even if core.autocrlf has not been set

From: Dmitry Potapov <dpotapov@gmail.com>
Date: Jul 24, 2008, 17:55 UTC
Message-ID: <20080724175513.GY2925@dpotapov.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.0807241811580.8986@racer>

On Thu, Jul 24, 2008 at 06:14:09PM +0100, Johannes Schindelin wrote:

Show 7 quoted lines

> On Thu, 24 Jul 2008, Dmitry Potapov wrote:
> > 
> > Here is the average based on 3 attempts:
> > 0.232s with autocrlf=false
> > 0.265s with autocrlf=input (14% increase)
> 
> And you tested... on git.git?  One of the smallest serious Git users?

If you take a huge repo, you are going to be bound by disk IO unless huge amount memory, so all files reside in the filesystem cache.

> 
> If you want to come close to the hard cases (that you would punish with 
> setting autocrlf = input, not yourself of course), test _at least_ the 
> Linux kernel.

false input 6.913s 8.426s 6.922s 8.337s 6.969s 8.335s 6.975s 8.386s 6.939s 8.435s 6.954s 8.320s

autocrlf=input takes 20% more than autocrlf=false, which is rather strange, because I clearly saw some disk activity... so I expected it to be less...

In any case, this test is rather artificial, and the real one should be is of course applying patches... Maybe I will try that later...

Dmitry