Re: [PATCH] Respect crlf attribute even if core.autocrlf has not been set

From: Eyvind Bernhardsen <eyvind-git@orakel.ntnu.no>
Date: Jul 25, 2008, 12:30 UTC
Message-ID: <E0666371-5C5E-4AA9-B67A-16C42477865B@orakel.ntnu.no>
In-Reply-To: <alpine.DEB.1.00.0807250159420.4140@eeepc-johanness>

On 25. juli. 2008, at 02.01, Johannes Schindelin wrote:

Show 6 quoted lines

>> Um, what?  This discussion is about figuring out when Git should mess
>> with the line endings a user is trying to commit.
>
> This discusion is about when Git should mess with _content_ at all.
>
> It is not limited to line endings.

Fair enough. Did you read the rest of my email to see when I think Git should mess with content? I've thought about it, and being able to do stuff like this in .gitattributes would work for me:

* eol=auto
*.bat eol=crlf
Makefile eol=lf
bin/magic-binary eol=none

I.e. "detect line endings and do CRLF->LF conversion on all files except *.bat (*->CRLF), Makefile (*->LF) and bin/magic-binary (do nothing)".

The closest you can get today is by setting core.autocrlf to "input" and having this in .gitattributes:

*.bat -crlf bin/magic-binary -crlf

...but "core.autocrlf" is not versioned and applies to _all_ repositories, and anyone who doesn't have the correct setting can mess the repository up. There's also no way of saying "this file should have LF line endings, even with autocrlf=true".

One problem is that the autocrlf setting mixes "I want LF only in my repositories" and "I like to have CRLFs in my working directory" into one config variable. Instead, I'd like to have a config setting that specifies which line ending form I prefer: "when a text file is marked eol=auto, convert LFs to CRLFs on checkout".

Does this make sense to anyone but me?

> Ciao,
> Dscho "who personally could not care less about CR if it was not for  
> M$'
> stupidity"

Well, we agree on that.

-- 
Eyvind Bernhardsen