Re: [PATCH] Respect crlf attribute even if core.autocrlf has not been set

From: Dmitry Potapov <dpotapov@gmail.com>
Date: Jul 25, 2008, 14:01 UTC
Message-ID: <20080725140142.GB2925@dpotapov.dyndns.org>
In-Reply-To: <E0666371-5C5E-4AA9-B67A-16C42477865B@orakel.ntnu.no>

On Fri, Jul 25, 2008 at 02:30:16PM +0200, Eyvind Bernhardsen wrote:

Show 13 quoted lines

> 
> Fair enough.  Did you read the rest of my email to see when I think  
> Git should mess with content?  I've thought about it, and being able  
> to do stuff like this in .gitattributes would work for me:
> 
> * eol=auto
> *.bat eol=crlf
> Makefile eol=lf
> bin/magic-binary eol=none
> 
> I.e. "detect line endings and do CRLF->LF conversion on all files  
> except *.bat (*->CRLF), Makefile (*->LF) and bin/magic-binary (do  
> nothing)".

I suppose "* eol=auto" means to convert CRLF->LF on checkin and LF->native on checkout?

Also, perhaps, it should be also possible to explicitly specify: *.txt eol=native which is the same as 'auto' but without guessing whether it is text or not.

> ...but "core.autocrlf" is not versioned and applies to _all_  
> repositories, and anyone who doesn't have the correct setting can mess  
> the repository up.

I think the real issue here is not as much about being or not being versioned, but about forcing and not forcing anything on users.

If we had core.autocrlf=input as default then clueless users will not checkin files with the incorrect ending. But there is an objection to that -- you penalize those who always have good endings. And even the fact that is merely default value that you can easily change to false does not convince everyone.

The same can be said about your
* eol=auto
It forces conversion on everyone, even on those who do not need it.
Of course, you can say those projects that do not have the problem with
clueless users putting text files with incorrect end-of-lines will not
have lines like that in their .gitattribute. Yet, if I participate in
that project, why do I have to pay the price for this conversion just
because someone stupid can mess up line-endings?

> There's also no way of saying "this file should  
> have LF line endings, even with autocrlf=true".

Actually, there is

*.sh crlf=input

i.e. I want my shell files to have LF even I normally use CRLF for all other files (on Windows).

Show 6 quoted lines

> 
> One problem is that the autocrlf setting mixes "I want LF only in my  
> repositories" and "I like to have CRLFs in my working directory" into  
> one config variable.  Instead, I'd like to have a config setting that  
> specifies which line ending form I prefer: "when a text file is marked  
> eol=auto, convert LFs to CRLFs on checkout".

Following your style above, I believe it should be defined as native-eol=crlf

but there are people who do not want to pay any price for conversion. Currently, "core.autocrlf=false" means to do nothing about end-of-lines, and even to ignore setting in .gitattributes. Should it be possible to disable *any* conversion on checkin and checkout? Should this be that value be the default, which most users use?

Dmitry -- If you write a program that any idiot can use, only idiots will use it.