Re: [PATCH v3 5/6] fn_out_diff_words_aux: Handle common diff line more carefully
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 5, 2008, 12:11 UTC
- Message-ID
- <alpine.DEB.1.00.0805051310550.30431@racer>
- In-Reply-To
- <46dff0320805040953i4230a686j8e8d63eaa6728c2f@mail.gmail.com>
Hi,
On Mon, 5 May 2008, Ping Yin wrote:
Show 19 quoted lines
> On Sun, May 4, 2008 at 5:54 PM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> > On Sun, 4 May 2008, Ping Yin wrote:
> >
> > > Before feeding minus and plus lines into xdi_diff, we replace non
> > > word characters with '\n'. So we need recover the replaced
> > > character (always the last character) in the callback
> > > fn_out_diff_words_aux.
> > >
> > > Therefore, a common diff line beginning with ' ' is not always a
> > > real common line.
> >
> > Umm, why?
>
> Because we need recover the replaced character.
>
> Say, for a common diff line " foo", after restoring the replaced
> character, the corresponding line in minus and plus may be different.
> For example, "foo(" and "foo)".Why do I have to spend time trying to figure out what you meant, write an email, and get the explanation only in a response (i.e. not the commit message, where it belongs)?
Ciao, Dscho