git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/6] fn_out_diff_words_aux: Use short variable name

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 5, 2008, 12:05 UTC
Message-ID
<alpine.DEB.1.00.0805051305280.30431@racer>
In-Reply-To
<46dff0320805040939t6290ed1dsad79d8de99c7cdde@mail.gmail.com>
Hi,
On Mon, 5 May 2008, Ping Yin wrote:
Show 10 quoted lines
> On Sun, May 4, 2008 at 5:47 PM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> > Hi,
> >
> >  the use of this patch evades me.  Care to defend why it is necessary?
> >  Preferably in the commit message?
> >
> 
> In fn_out_diff_words_aux, we use diff_words->plus in so many places.
> So just use shorter name to save typing and avoid typo.
Me, on the other hand, I find "diff_words->plus" so much better to read.

Ciao, Dscho

Previous: Ping YinNext: Johannes Schindelin
Message 74 of 92 in “Make words boundary for --color-words configurable”
  1. Make words boundary for --color-words configurablePing Yin, May 2, 2008
  2. Junio C HamanoMay 2, 2008
  3. Ping YinMay 2, 2008
  4. Make boundary characters for --color-words configurablePing Yin, May 2, 2008
  5. Ping YinMay 2, 2008
  6. Ping YinMay 2, 2008
  7. 0/5 Make boundary characters for --color-words configurablePing Yin, May 3, 2008
  8. 1/5 diff.c: Remove code redundancy in diff_words_showPing Yin, May 3, 2008
  9. 2/5 diff.c: Use show variable name in fn_out_diff_words_auxPing Yin, May 3, 2008
  10. 3/5 diff.c: Fix --color-words showing trailing deleted words at another linePing Yin, May 3, 2008
  11. 4/5 Make boundary characters for --color-words configurablePing Yin, May 3, 2008
  12. 5/5 fn_out_diff_words_aux: Handle common diff line more carefullyPing Yin, May 3, 2008
  13. Junio C HamanoMay 3, 2008
  14. Teemu LikonenMay 3, 2008
  15. Ping YinMay 4, 2008
  16. Johannes SchindelinMay 4, 2008
  17. Ping YinMay 4, 2008
  18. Junio C HamanoMay 4, 2008
  19. Jakub NarebskiMay 4, 2008
  20. Teemu LikonenMay 4, 2008
  21. Johannes SchindelinMay 5, 2008
  22. Ping YinMay 5, 2008
  23. Junio C HamanoMay 5, 2008
  24. Ping YinMay 5, 2008
  25. Ping YinMay 6, 2008
  26. Johannes SchindelinMay 6, 2008
  27. Ping YinMay 7, 2008
  28. Johannes SchindelinMay 7, 2008
  29. Ping YinMay 7, 2008
  30. Johannes SchindelinMay 7, 2008
  31. Ping YinMay 7, 2008
  32. Junio C HamanoMay 7, 2008
  33. Junio C HamanoMay 7, 2008
  34. Jeff KingMay 7, 2008
  35. Junio C HamanoMay 7, 2008
  36. Jeff KingMay 7, 2008
  37. Teemu LikonenMay 8, 2008
  38. Ping YinMay 10, 2008
  39. Teemu LikonenMay 10, 2008
  40. Ping YinMay 11, 2008
  41. Ping YinMay 11, 2008
  42. Junio C HamanoMay 11, 2008
  43. Ping YinMay 12, 2008
  44. Jakub NarebskiMay 12, 2008
  45. Junio C HamanoMay 12, 2008
  46. Jakub NarebskiMay 12, 2008
  47. Ping YinMay 13, 2008
  48. Ping YinMay 13, 2008
  49. Ping YinMay 10, 2008
  50. Johannes SchindelinMay 5, 2008
  51. Ping YinMay 5, 2008
  52. Junio C HamanoMay 3, 2008
  53. Ping YinMay 3, 2008
  54. Junio C HamanoMay 3, 2008
  55. Junio C HamanoMay 3, 2008
  56. 0/6 --color-words improvementPing Yin, May 4, 2008
  57. 1/6 diff.c: Remove code redundancy in diff_words_showPing Yin, May 4, 2008
  58. 2/6 fn_out_diff_words_aux: Use short variable namePing Yin, May 4, 2008
  59. 3/6 --color-words: Fix showing trailing deleted words at another linePing Yin, May 4, 2008
  60. 4/6 --color-words: Make non-word characters configurablePing Yin, May 4, 2008
  61. 5/6 fn_out_diff_words_aux: Handle common diff line more carefullyPing Yin, May 4, 2008
  62. 6/6 --color-words: Add test t4030Ping Yin, May 4, 2008
  63. Johannes SchindelinMay 4, 2008
  64. Ping YinMay 4, 2008
  65. Johannes SchindelinMay 5, 2008
  66. Ping YinMay 5, 2008
  67. Junio C HamanoMay 4, 2008
  68. Ping YinMay 4, 2008
  69. Johannes SchindelinMay 4, 2008
  70. Ping YinMay 4, 2008
  71. Johannes SchindelinMay 5, 2008
  72. Johannes SchindelinMay 4, 2008
  73. Ping YinMay 4, 2008
  74. Johannes SchindelinMay 5, 2008
  75. Johannes SchindelinMay 4, 2008
  76. Teemu LikonenMay 2, 2008
  77. Ping YinMay 3, 2008
  78. Dirk SüsserottMay 3, 2008
  79. Ping YinMay 3, 2008
  80. --color-words: Make the word characters configurableJohannes Schindelin, May 3, 2008
  81. Ping YinMay 3, 2008
  82. Johannes SchindelinMay 3, 2008
  83. Teemu LikonenMay 3, 2008
  84. Johannes SchindelinMay 4, 2008
  85. Junio C HamanoMay 3, 2008
  86. Johannes SchindelinMay 4, 2008
  87. Johannes SchindelinMay 2, 2008
  88. Teemu LikonenMay 2, 2008
  89. Ping YinMay 2, 2008
  90. Teemu LikonenMay 2, 2008
  91. Ping YinMay 2, 2008
  92. Jakub NarebskiMay 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.