Re: [PATCH v2 4/5] Make boundary characters for --color-words configurable

From: Ping Yin <pkufranky@gmail.com>
Date: May 7, 2008, 14:11 UTC
Message-ID: <46dff0320805070711vc4c9a63uba3eaa7743381f20@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0805071408360.30431@racer>

On Wed, May 7, 2008 at 9:10 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 5 quoted lines

>  > Sorry, but i can't parse both sentences, especially Bikeshedding and
>  > "punch holes into".
>
>  "punch holes into": find cases where Junio's proposed algorithm breaks
>  down.

I think the --color-words={char,punct,word} covers most of the cases that junio mentioned, except the case that a token can be a run of word chars, a run of non-word chars or a run of whitespaces.

If anyone is interested in this case, he can extend --color-words with a fourth option or tokenizer (i havn't yet found a good name for this tokenizer).

Of course, if neccessary, one can implement other language-specific tokenizers.

However, i think the 3 tokenizers i mentioned is enough for most cases.

Show 5 quoted lines

>
>  "bikeshedding": discussing minor implementation details that are not
>  really interesting at this stage.  See also
>  http://en.wikipedia.org/wiki/Bikeshedding.
>

See. THX.

-- 
Ping Yin