Re: [PATCH] --color-words: Make the word characters configurable
- From
- Teemu Likonen <tlikonen@iki.fi>
- Date
- May 3, 2008, 14:43 UTC
- Message-ID
- <20080503144337.GA7987@mithlond.arda.local>
- In-Reply-To
- <alpine.DEB.1.00.0805031501290.30431@racer>
Johannes Schindelin wrote (2008-05-03 15:03 +0100):
Show 8 quoted lines
> Now, you can specify which characters are to be interpreted as word > characters with "--color-words=A-Za-z", or by setting the config > variable diff.wordCharacters. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > --- > > I would have preferred an approach like this.
Unfortunately this does not work at all with other than Ascii characters. It makes --color-words completely unusable for anything other than Ascii text. Sorry.
Ping Yin's version has also the problem that UTF-8 multibyte characters U+0080..U+10FFFF don't work in diff.nonwordchars. Fortunately the most important word delimiters are in U+0000..U+007F (=Ascii) area so Ping's version is perfectly usable with Unicode text. (Even the old --color-words behaviour with only SPACE as non-word char was perfectly usable with Unicode text.) I, too, would like to see Ping's patch series merged in.