Re: [PATCH 6/9] t7900: clean up large EXPENSIVE repository
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jul 3, 2026, 05:42 UTC
- Message-ID
- <akdLryzNx1Vi2BnL@pks.im>
- In-Reply-To
- <20260702213044.GD2051171@coredump.intra.peff.net>
On Thu, Jul 02, 2026 at 05:30:44PM -0400, Jeff King wrote:
Show 17 quoted lines
> On Thu, Jul 02, 2026 at 02:00:59PM +0200, Patrick Steinhardt wrote: > > > One of the tests in t7900 is marked with EXPENSIVE because we create a > > repository with 2GB of data that we end up repacking. We never clean up > > that repository though, so we occupy the full 2GB of data until the end > > of the test suite. Besides clogging our disk, it also means that all > > subsequent tests may have to repack this data multiple times. > > Hmm, I hoped this would drop the time to run t7900 with --long, but it > takes about 1m40s both before and after your patch (vs ~6s without > --long). Just looking at the script, I'd guess that it's because the > subsequent repacks are mostly incremental or geometric, so they don't > need to write the big pack. > > Oh well. It still seems like an obvious improvement, though, both in > terms of peak disk usage and avoiding unwanted surprises when more tests > are added later.
Yeah, the commit message is a bit hand-wavy there indeed. I think the bigger argument here is that having a test that is marked as EXPENSIVE and that may influence subsequent tests is just a bad idea.
Patrick