git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 5/9] t7508: skip EXPENSIVE test that is broken without SIZE_T_IS_32BIT

From
Patrick Steinhardt <ps@pks.im>
Date
Jul 3, 2026, 09:24 UTC
Message-ID
<20260703-b4-pks-t-fixes-for-GIT-TEST-LONG-v2-5-79076a7e0c62@pks.im>
In-Reply-To
<20260703-b4-pks-t-fixes-for-GIT-TEST-LONG-v2-0-79076a7e0c62@pks.im>

One of the tests in t7508 is marked as EXPENSIVE because it ends up creating and adding files that are multiple gigabytes in size. This takes a while to complete, hence the EXPENSIVE prerequisite.

Besides being expensive though the test can only work on systems where `size_t` is at least 64 bit. This is because one of the created files is larger than 4GB, and because Git tracks object size via `size_t` it will eventually blow up.

This test has also been blowing up in the "linux32" CI job in GitHub Workflows since 7a094d68a2 (ci: run expensive tests on push builds to integration branches, 2026-05-08). But that job doesn't only fail, it also hangs, and that has been concealing the failure.

Fix the issue by marking the test as requiring 64 bit `size_t`.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 t/t7508-status.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t7508-status.sh b/t/t7508-status.sh
index c2057bc94c..dfdd78b6fe 100755
--- a/t/t7508-status.sh
+++ b/t/t7508-status.sh
@@ -1773,7 +1773,7 @@ test_expect_success 'slow status advice when core.untrackedCache true, and fsmon
 	)
 '
 
-test_expect_success EXPENSIVE 'status does not re-read unchanged 4 or 8 GiB file' '
+test_expect_success EXPENSIVE,SIZE_T_IS_64BIT 'status does not re-read unchanged 4 or 8 GiB file' '
 	(
 		mkdir large-file &&
 		cd large-file &&
-- 
2.55.0.795.g602f6c329a.dirty
Previous: Patrick SteinhardtNext: Junio C Hamano
Message 28 of 33 in “t: fixes and improvements for GIT_TEST_LONG”
  1. 0/9 t: fixes and improvements for GIT_TEST_LONGPatrick Steinhardt, Jul 2, 2026
  2. 1/9 README: add GitLab CI badge to make it more discoverablePatrick Steinhardt, Jul 2, 2026
  3. 2/9 t0021: skip EXPENSIVE test that is broken without SIZE_T_IS_32BITPatrick Steinhardt, Jul 2, 2026
  4. 3/9 t4141: fix inefficient use of dd(1)Patrick Steinhardt, Jul 2, 2026
  5. SZEDER GáborJul 2, 2026
  6. Patrick SteinhardtJul 3, 2026
  7. Jeff KingJul 2, 2026
  8. Patrick SteinhardtJul 3, 2026
  9. Jeff KingJul 3, 2026
  10. 4/9 t5608: reduce maximum disk usagePatrick Steinhardt, Jul 2, 2026
  11. 5/9 t7508: skip EXPENSIVE test that is broken without SIZE_T_IS_32BITPatrick Steinhardt, Jul 2, 2026
  12. Jeff KingJul 2, 2026
  13. Jeff KingJul 2, 2026
  14. 6/9 t7900: clean up large EXPENSIVE repositoryPatrick Steinhardt, Jul 2, 2026
  15. Jeff KingJul 2, 2026
  16. Patrick SteinhardtJul 3, 2026
  17. Jeff KingJul 3, 2026
  18. 7/9 t: use `test_bool_env` to parse GIT_TEST_LONGPatrick Steinhardt, Jul 2, 2026
  19. 8/9 gitlab-ci: disable RAM disk on macOS jobsPatrick Steinhardt, Jul 2, 2026
  20. 9/9 gitlab-ci: enable "GIT_TEST_LONG"Patrick Steinhardt, Jul 2, 2026
  21. 0/9 t: fixes and improvements for GIT_TEST_LONGPatrick Steinhardt, Jul 3, 2026
  22. 1/9 README: add GitLab CI badge to make it more discoverablePatrick Steinhardt, Jul 3, 2026
  23. 2/9 t0021: skip EXPENSIVE test that is broken without SIZE_T_IS_32BITPatrick Steinhardt, Jul 3, 2026
  24. Junio C HamanoJul 3, 2026
  25. Patrick SteinhardtJul 6, 2026
  26. 3/9 t4141: fix inefficient use of dd(1)Patrick Steinhardt, Jul 3, 2026
  27. 4/9 t5608: reduce maximum disk usagePatrick Steinhardt, Jul 3, 2026
  28. 5/9 t7508: skip EXPENSIVE test that is broken without SIZE_T_IS_32BITPatrick Steinhardt, Jul 3, 2026
  29. Junio C HamanoJul 3, 2026
  30. 6/9 t7900: clean up large EXPENSIVE repositoryPatrick Steinhardt, Jul 3, 2026
  31. 7/9 t: use `test_bool_env` to parse GIT_TEST_LONGPatrick Steinhardt, Jul 3, 2026
  32. 8/9 gitlab-ci: disable RAM disk on macOS jobsPatrick Steinhardt, Jul 3, 2026
  33. 9/9 gitlab-ci: enable "GIT_TEST_LONG"Patrick Steinhardt, Jul 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.