Re: [PATCH 5/9] t7508: skip EXPENSIVE test that is broken without SIZE_T_IS_32BIT
- From
Jeff King <peff@peff.net>
- Date
- Jul 2, 2026, 22:18 UTC
- Message-ID
- <20260702221858.GA2068937@coredump.intra.peff.net>
- In-Reply-To
- <20260702212235.GC2051171@coredump.intra.peff.net>
On Thu, Jul 02, 2026 at 05:22:35PM -0400, Jeff King wrote:
Show 16 quoted lines
> On Thu, Jul 02, 2026 at 02:00:58PM +0200, Patrick Steinhardt wrote: > > > This test has also been blowing up in the "linux32" CI job in GitHub > > Workflows since 7a094d68a2 (ci: run expensive tests on push builds to > > integration branches, 2026-05-08). But that job doesn't only fail, it > > also hangs, and that has been concealing the failure. > > One thing I don't understand about this and a few other patches in this > series: I've been getting passing GitHub Actions runs, including > linux32, even after that commit turned on the expensive jobs. > > From your description it sounds like it should _never_ work, but it does > for me. It's possible there's something going on in my CI builds that > would cause the expensive tests not to run, but I don't think so. Am I > misunderstanding the problem? Or is there something missing from the > analysis?
Ah, nevermind. It _is_ my setup. We run the expensive tests only on pull requests, or when pushing to some specific branches, none of which match the name of my particular integration branch.
Given all of the headaches I'm hesitant to "fix" my setup to run them, but I probably should. ;)
-Peff