git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/9] t0021: skip EXPENSIVE test that is broken without SIZE_T_IS_32BIT

From
Patrick Steinhardt <ps@pks.im>
Date
Jul 2, 2026, 12:00 UTC
Message-ID
<20260702-b4-pks-t-fixes-for-GIT-TEST-LONG-v1-2-76b4d7bab3d0@pks.im>
In-Reply-To
<20260702-b4-pks-t-fixes-for-GIT-TEST-LONG-v1-0-76b4d7bab3d0@pks.im>

One of the tests in t0021 writes a 2GB file and then roundtrips it through the clean/sumdge filters. This test is broken on 32 bit platforms because they typically don't handle files larger then `SSIZE_MAX` well at all.

While our CI has a "linux32" job that should in theory hit this issue, we never noticed it because we didn't use to run EXPENSIVE tests until 7a094d68a2 (ci: run expensive tests on push builds to integration branches, 2026-05-08). And after that commit, the test does not fail but instead hangs completely.

Ideally, we'd of course properly detect this situation and then test for it. In practice, this turns out to be hard as the test failure are not reliable as they often (but not always) run into ENOMEM errors.

Instead, skip the test altogether.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 t/t0021-conversion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh
index 033b00a364..7b9a0ca877 100755
--- a/t/t0021-conversion.sh
+++ b/t/t0021-conversion.sh
@@ -296,7 +296,7 @@ test_expect_success 'filter that does not read is fine' '
 	test_cmp expect actual
 '
 
-test_expect_success EXPENSIVE 'filter large file' '
+test_expect_success EXPENSIVE,SIZE_T_IS_64BIT 'filter large file' '
 	test_config filter.largefile.smudge cat &&
 	test_config filter.largefile.clean cat &&
 	test_seq -f "%1048576d" 1 2048 >2GB &&
-- 
2.55.0.795.g602f6c329a.dirty
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 3 of 33 in “t: fixes and improvements for GIT_TEST_LONG”
  1. 0/9 t: fixes and improvements for GIT_TEST_LONGPatrick Steinhardt, Jul 2, 2026
  2. 1/9 README: add GitLab CI badge to make it more discoverablePatrick Steinhardt, Jul 2, 2026
  3. 2/9 t0021: skip EXPENSIVE test that is broken without SIZE_T_IS_32BITPatrick Steinhardt, Jul 2, 2026
  4. 3/9 t4141: fix inefficient use of dd(1)Patrick Steinhardt, Jul 2, 2026
  5. SZEDER GáborJul 2, 2026
  6. Patrick SteinhardtJul 3, 2026
  7. Jeff KingJul 2, 2026
  8. Patrick SteinhardtJul 3, 2026
  9. Jeff KingJul 3, 2026
  10. 4/9 t5608: reduce maximum disk usagePatrick Steinhardt, Jul 2, 2026
  11. 5/9 t7508: skip EXPENSIVE test that is broken without SIZE_T_IS_32BITPatrick Steinhardt, Jul 2, 2026
  12. Jeff KingJul 2, 2026
  13. Jeff KingJul 2, 2026
  14. 6/9 t7900: clean up large EXPENSIVE repositoryPatrick Steinhardt, Jul 2, 2026
  15. Jeff KingJul 2, 2026
  16. Patrick SteinhardtJul 3, 2026
  17. Jeff KingJul 3, 2026
  18. 7/9 t: use `test_bool_env` to parse GIT_TEST_LONGPatrick Steinhardt, Jul 2, 2026
  19. 8/9 gitlab-ci: disable RAM disk on macOS jobsPatrick Steinhardt, Jul 2, 2026
  20. 9/9 gitlab-ci: enable "GIT_TEST_LONG"Patrick Steinhardt, Jul 2, 2026
  21. 0/9 t: fixes and improvements for GIT_TEST_LONGPatrick Steinhardt, Jul 3, 2026
  22. 1/9 README: add GitLab CI badge to make it more discoverablePatrick Steinhardt, Jul 3, 2026
  23. 2/9 t0021: skip EXPENSIVE test that is broken without SIZE_T_IS_32BITPatrick Steinhardt, Jul 3, 2026
  24. Junio C HamanoJul 3, 2026
  25. Patrick SteinhardtJul 6, 2026
  26. 3/9 t4141: fix inefficient use of dd(1)Patrick Steinhardt, Jul 3, 2026
  27. 4/9 t5608: reduce maximum disk usagePatrick Steinhardt, Jul 3, 2026
  28. 5/9 t7508: skip EXPENSIVE test that is broken without SIZE_T_IS_32BITPatrick Steinhardt, Jul 3, 2026
  29. Junio C HamanoJul 3, 2026
  30. 6/9 t7900: clean up large EXPENSIVE repositoryPatrick Steinhardt, Jul 3, 2026
  31. 7/9 t: use `test_bool_env` to parse GIT_TEST_LONGPatrick Steinhardt, Jul 3, 2026
  32. 8/9 gitlab-ci: disable RAM disk on macOS jobsPatrick Steinhardt, Jul 3, 2026
  33. 9/9 gitlab-ci: enable "GIT_TEST_LONG"Patrick Steinhardt, Jul 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.