Re: [PATCH 6/9] t7900: clean up large EXPENSIVE repository
On Fri, Jul 03, 2026 at 07:42:07AM +0200, Patrick Steinhardt wrote:
Show 13 quoted lines
> > Hmm, I hoped this would drop the time to run t7900 with --long, but it
> > takes about 1m40s both before and after your patch (vs ~6s without
> > --long). Just looking at the script, I'd guess that it's because the
> > subsequent repacks are mostly incremental or geometric, so they don't
> > need to write the big pack.
> >
> > Oh well. It still seems like an obvious improvement, though, both in
> > terms of peak disk usage and avoiding unwanted surprises when more tests
> > are added later.
>
> Yeah, the commit message is a bit hand-wavy there indeed. I think the
> bigger argument here is that having a test that is marked as EXPENSIVE
> and that may influence subsequent tests is just a bad idea.
Yes, very much agreed.
-Peff