Re: [PATCH v2 1/4] Add Travis CI support

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 5, 2015, 09:43 UTC
Message-ID: <a10d494741e1252eb0d55d9120d00a07@dscho.org>
In-Reply-To: <1443981977-64604-2-git-send-email-larsxschneider@gmail.com>

Hi Lars,

On 2015-10-04 20:06, larsxschneider@gmail.com wrote:

> From: Lars Schneider <larsxschneider@gmail.com>
> 
> The tests are executed on "Ubuntu 12.04 LTS Server Edition 64 bit" and
> on "OS X Mavericks" using gcc and clang.

I think that the word "currently" is missing from this description, as it is not something this patch controls (but Travis CI's infrastructure).

> Perforce and Git-LFS are installed and therefore available for the
> respective tests.

This is *the* bonus of using Travis CI over BuildHive (which is enabled in Git for Windows' fork of git/git): you can install additional dependencies for more extensive testing. Oh, and it tests with clang and on MacOSX, too, which would reduce the number of fixer-upper patches when git/git introduced yet Another Change That Works Only On Linux.

> +before_script:
> +  - >
> +    if [ ${TRAVIS_OS_NAME:-'linux'} = 'linux' ]; then

Maybe for readability use

    case "${TRAVIS_OS_NAME:-linux}" in
    linux)
        ...

Thanks, Dscho