git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/4] git-p4: Fix t9815 git-p4-submit-fail test case on OS X

From
larsxschneider@gmail.com <larsxschneider@gmail.com>
Date
Oct 4, 2015, 18:06 UTC
Message-ID
<1443981977-64604-4-git-send-email-larsxschneider@gmail.com>
In-Reply-To
<1443981977-64604-1-git-send-email-larsxschneider@gmail.com>
From: Lars Schneider <larsxschneider@gmail.com>

The stats command works differently on OS X compared to Linux. Detect OS X and execute the appropriate assertions.

Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
---
 t/t9815-git-p4-submit-fail.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/t/t9815-git-p4-submit-fail.sh b/t/t9815-git-p4-submit-fail.sh
index 4cff6a7..520b812 100755
--- a/t/t9815-git-p4-submit-fail.sh
+++ b/t/t9815-git-p4-submit-fail.sh
@@ -417,8 +417,12 @@ test_expect_success 'cleanup chmod after submit cancel' '
 		! p4 fstat -T action text &&
 		test_path_is_file text+x &&
 		! p4 fstat -T action text+x &&
-		if test_have_prereq !CYGWIN
-		then
+		if test_have_prereq CYGWIN; then
+			: # NOOP
+		elif test_have_prereq DARWIN; then
+			stat -f %Sp text | egrep ^-r-- &&
+			stat -f %Sp text+x | egrep ^-r-x
+		else
 			stat --format=%A text | egrep ^-r-- &&
 			stat --format=%A text+x | egrep ^-r-x
 		fi
-- 
2.5.1
Previous: Lars SchneiderNext: Junio C Hamano
Message 7 of 16 in “Add Travis CI support”
  1. 0/4 Add Travis CI supportlarsxschneider@gmail.com, Oct 4, 2015
  2. 1/4 Add Travis CI supportlarsxschneider@gmail.com, Oct 4, 2015
  3. Johannes SchindelinOct 5, 2015
  4. 2/4 Add prereq to detect OS Xlarsxschneider@gmail.com, Oct 4, 2015
  5. Junio C HamanoOct 4, 2015
  6. Lars SchneiderOct 4, 2015
  7. 3/4 git-p4: Fix t9815 git-p4-submit-fail test case on OS Xlarsxschneider@gmail.com, Oct 4, 2015
  8. Junio C HamanoOct 4, 2015
  9. Lars SchneiderOct 4, 2015
  10. Pete WyckoffOct 4, 2015
  11. Torsten BögershausenOct 5, 2015
  12. 4/4 git-p4: Disable t9819 git-p4-case-folding test on OS Xlarsxschneider@gmail.com, Oct 4, 2015
  13. Junio C HamanoOct 4, 2015
  14. Lars SchneiderOct 4, 2015
  15. Junio C HamanoOct 4, 2015
  16. Johannes SchindelinOct 5, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.