Re: [PATCH v2 2/4] Add prereq to detect OS X
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Oct 4, 2015, 18:46 UTC
- Message-ID
- <580774DE-807D-411C-B6B4-A72D273038C1@gmail.com>
- In-Reply-To
- <xmqq612m1oay.fsf@gitster.mtv.corp.google.com>
On 04 Oct 2015, at 11:28, Junio C Hamano <gitster@pobox.com> wrote:
Show 12 quoted lines
> larsxschneider@gmail.com writes: > >> From: Lars Schneider <larsxschneider@gmail.com> >> >> Some Unix tools differ between Linux and Mac OS X. Add this prereq to >> detect OS X and handle it appropriately. > > If my comment on 4/4 turns out to be to the point, then we do not > need this, I presume? In general, we really should think three > times before adding prerequisite based on the platform. A prereq > based on a specific feature of the platform is often what we want > instead.
Agreed. I will remove this commit in the next roll.
Thanks, Lars