Re: [PATCH v2 3/4] git-p4: Fix t9815 git-p4-submit-fail test case on OS X

From: Lars Schneider <larsxschneider@gmail.com>
Date: Oct 4, 2015, 18:44 UTC
Message-ID: <90C13A5C-AB19-4E5C-A317-15B3D182444D@gmail.com>
In-Reply-To: <xmqqegha1oj6.fsf@gitster.mtv.corp.google.com>

On 04 Oct 2015, at 11:23, Junio C Hamano <gitster@pobox.com> wrote:

Show 16 quoted lines

> larsxschneider@gmail.com writes:
> 
>> +		if test_have_prereq CYGWIN; then
>> +			: # NOOP
>> +		elif test_have_prereq DARWIN; then
>> +			stat -f %Sp text | egrep ^-r-- &&
>> +			stat -f %Sp text+x | egrep ^-r-x
>> +		else
>> 			stat --format=%A text | egrep ^-r-- &&
>> 			stat --format=%A text+x | egrep ^-r-x
>> 		fi
> 
> Not a new problem but why do we need "stat" here?
> 
> Shouldn't "test -r", "! test -x", and their usual friends be
> sufficient for the purpose of the test and are more portable?

Good question. The stat call was introduced with df9c545 by Pete Wyckoff. @Pete, @Luke: Are you aware of any particular reason for stat?

Thanks, Lars