Re: [PATCH v2 4/4] git-p4: Disable t9819 git-p4-case-folding test on OS X
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Oct 4, 2015, 18:38 UTC
- Message-ID
- <E363C89B-7039-49F6-B723-8609DBAF2C64@gmail.com>
- In-Reply-To
- <xmqqa8ry1ods.fsf@gitster.mtv.corp.google.com>
On 04 Oct 2015, at 11:26, Junio C Hamano <gitster@pobox.com> wrote:
Show 39 quoted lines
> larsxschneider@gmail.com writes: > >> From: Lars Schneider <larsxschneider@gmail.com> >> >> The OS X file system is case insensitive by default. Consequently this >> test does not apply. >> >> Signed-off-by: Lars Schneider <larsxschneider@gmail.com> >> --- >> t/t9819-git-p4-case-folding.sh | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/t/t9819-git-p4-case-folding.sh b/t/t9819-git-p4-case-folding.sh >> index 78f1d0f..c69ae47 100755 >> --- a/t/t9819-git-p4-case-folding.sh >> +++ b/t/t9819-git-p4-case-folding.sh >> @@ -4,6 +4,11 @@ test_description='interaction with P4 case-folding' >> >> . ./lib-git-p4.sh >> >> +if test_have_prereq DARWIN; then >> + skip_all='skipping P4 case-folding tests; OS X file system is case insensitive by default' >> + test_done >> +fi > > Makes one wonder what should happen on Windows, or vfat mounted on > Linux for that matter. IOW, shouldn't the prerequisite be more like > "do not run any of these tests if the filesystem does not allow us > to have two files in different cases at the same time"? > > Perhaps > > if ! test_have_prereq CASE_INSENSITIVE_FS > then > skip_all=... > test_done > fi > > instead, or something?
Agreed! Although I think the “!” in the if clause is not correct. By the way... what formatting should I use?
if foo then bar
or
if foo; then bar
I think the latter is more used in the code base.
- Lars