Re: [PATCH 1/2] t: move reftable/basics_test.c to the unit testing framework
- From
Patrick Steinhardt <ps@pks.im>
- Date
- May 29, 2024, 06:00 UTC
- Message-ID
- <ZlbEdZNbrVNEHFLw@tanuki>
- In-Reply-To
- <CAP8UFD2ObwdQVE9Ta+th6O-FC9cTR8sNxsrSQWBXosjP4ccqSQ@mail.gmail.com>
On Tue, May 28, 2024 at 02:34:05PM +0200, Christian Couder wrote:
Show 21 quoted lines
> On Tue, May 28, 2024 at 1:45 PM Chandra Pratap > <chandrapratap3519@gmail.com> wrote: > > > diff --git a/reftable/basics_test.c b/t/unit-tests/t-reftable-basics.c > > similarity index 60% > > rename from reftable/basics_test.c > > rename to t/unit-tests/t-reftable-basics.c > > index 997c4d9e01..b6088e1ddd 100644 > > --- a/reftable/basics_test.c > > +++ b/t/unit-tests/t-reftable-basics.c > > @@ -1,16 +1,6 @@ > > -/* > > -Copyright 2020 Google LLC > > - > > -Use of this source code is governed by a BSD-style > > -license that can be found in the LICENSE file or at > > -https://developers.google.com/open-source/licenses/bsd > > -*/ > > Are we sure it's Ok to remove the above Copyright? Or is it safer to > just move it over (and perhaps add our own)?
Good question indeed. We should retain the copyright header given that these source files have a different license compared to the rest of the codebase.
Patrick