git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t: move reftable/basics_test.c to the unit testing framework

From
Christian Couder <christian.couder@gmail.com>
Date
May 28, 2024, 12:34 UTC
Message-ID
<CAP8UFD2ObwdQVE9Ta+th6O-FC9cTR8sNxsrSQWBXosjP4ccqSQ@mail.gmail.com>
In-Reply-To
<20240528113856.8348-2-chandrapratap3519@gmail.com>

On Tue, May 28, 2024 at 1:45 PM Chandra Pratap <chandrapratap3519@gmail.com> wrote:

Show 15 quoted lines
> diff --git a/reftable/basics_test.c b/t/unit-tests/t-reftable-basics.c
> similarity index 60%
> rename from reftable/basics_test.c
> rename to t/unit-tests/t-reftable-basics.c
> index 997c4d9e01..b6088e1ddd 100644
> --- a/reftable/basics_test.c
> +++ b/t/unit-tests/t-reftable-basics.c
> @@ -1,16 +1,6 @@
> -/*
> -Copyright 2020 Google LLC
> -
> -Use of this source code is governed by a BSD-style
> -license that can be found in the LICENSE file or at
> -https://developers.google.com/open-source/licenses/bsd
> -*/

Are we sure it's Ok to remove the above Copyright? Or is it safer to just move it over (and perhaps add our own)?

Previous: Chandra PratapNext: Patrick Steinhardt
Message 3 of 9 in “t: port reftable/basics_test.c to the unit testing”
  1. Chandra PratapMay 28, 2024
  2. 1/2 t: move reftable/basics_test.c to the unit testing frameworkChandra Pratap, May 28, 2024
  3. Christian CouderMay 28, 2024
  4. Patrick SteinhardtMay 29, 2024
  5. Patrick SteinhardtMay 29, 2024
  6. 2/2 t: improve upon reftable/basics_test.c in the unit testing frameworkChandra Pratap, May 28, 2024
  7. Christian CouderMay 28, 2024
  8. Patrick SteinhardtMay 29, 2024
  9. Christian CouderMay 28, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.