Re: [PATCH 1/2] t: move reftable/basics_test.c to the unit testing framework

From: Patrick Steinhardt <ps@pks.im>
Date: May 29, 2024, 06:00 UTC
Message-ID: <ZlbEcHL3fEFXbt-H@tanuki>
In-Reply-To: <20240528113856.8348-2-chandrapratap3519@gmail.com>

On Tue, May 28, 2024 at 05:00:02PM +0530, Chandra Pratap wrote:

Show 18 quoted lines

> --- a/reftable/basics_test.c
> +++ b/t/unit-tests/t-reftable-basics.c
> @@ -1,16 +1,6 @@
> -/*
> -Copyright 2020 Google LLC
> -
> -Use of this source code is governed by a BSD-style
> -license that can be found in the LICENSE file or at
> -https://developers.google.com/open-source/licenses/bsd
> -*/
> -
> -#include "system.h"
> -
> -#include "basics.h"
> -#include "test_framework.h"
> -#include "reftable-tests.h"
> +#include "test-lib.h"
> +#include "reftable/system.h"

There is no need to include "reftable/system.h" explicitly as it is already transitively included via "reftable/basics.h". The same should be true for all other reftable headers.

Patrick