git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t: improve upon reftable/basics_test.c in the unit testing framework

From
Patrick Steinhardt <ps@pks.im>
Date
May 29, 2024, 06:00 UTC
Message-ID
<ZlbEanuHHlwyaRfT@tanuki>
In-Reply-To
<CAP8UFD02Ck0M2AOmTtJO3gHr3w+3Of7BAAa0Rbc=CtMms60nyA@mail.gmail.com>
On Tue, May 28, 2024 at 02:46:17PM +0200, Christian Couder wrote:
Show 21 quoted lines
> On Tue, May 28, 2024 at 1:40 PM Chandra Pratap
> <chandrapratap3519@gmail.com> wrote:
> >
> > Enhance the new test for reftable/basics.{c, h} in the unit testing
> > framework. The enhancements include:
> > - Move tests for functions in reftable/basics.{c, h} from
> > reftable/record_test.c and reftable/stack_test.c to the new unit test.
> 
> It might be easier for readers if one patch moved tests from
> reftable/record_test.c and a separate patch moved tests from
> reftable/stack_test.c.
> 
> > - Add tests for functions that are not currently tested, like put_be16.
> 
> This could perhaps be done in a separate patch.
> 
> > - Improve the test-cases for the already existing tests.
> 
> Are these improvements to tests that were moved in patch 1/2 of this
> series? If that's the case, these improvements could be in a separate
> patch too.

Some of the test cases are extended to also cover additional edge cases. But I agree that this is easy to miss, and also think that this patch should be split up further.

Patrick
Previous: Christian CouderNext: Christian Couder
Message 8 of 9 in “t: port reftable/basics_test.c to the unit testing”
  1. Chandra PratapMay 28, 2024
  2. 1/2 t: move reftable/basics_test.c to the unit testing frameworkChandra Pratap, May 28, 2024
  3. Christian CouderMay 28, 2024
  4. Patrick SteinhardtMay 29, 2024
  5. Patrick SteinhardtMay 29, 2024
  6. 2/2 t: improve upon reftable/basics_test.c in the unit testing frameworkChandra Pratap, May 28, 2024
  7. Christian CouderMay 28, 2024
  8. Patrick SteinhardtMay 29, 2024
  9. Christian CouderMay 28, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.