Re: [PATCH 2/2] t: improve upon reftable/basics_test.c in the unit testing framework

From: Christian Couder <christian.couder@gmail.com>
Date: May 28, 2024, 12:46 UTC
Message-ID: <CAP8UFD02Ck0M2AOmTtJO3gHr3w+3Of7BAAa0Rbc=CtMms60nyA@mail.gmail.com>
In-Reply-To: <20240528113856.8348-3-chandrapratap3519@gmail.com>

On Tue, May 28, 2024 at 1:40 PM Chandra Pratap <chandrapratap3519@gmail.com> wrote:

Show 5 quoted lines

>
> Enhance the new test for reftable/basics.{c, h} in the unit testing
> framework. The enhancements include:
> - Move tests for functions in reftable/basics.{c, h} from
> reftable/record_test.c and reftable/stack_test.c to the new unit test.

It might be easier for readers if one patch moved tests from reftable/record_test.c and a separate patch moved tests from reftable/stack_test.c.

> - Add tests for functions that are not currently tested, like put_be16.

This could perhaps be done in a separate patch.

> - Improve the test-cases for the already existing tests.

Are these improvements to tests that were moved in patch 1/2 of this series? If that's the case, these improvements could be in a separate patch too.