Re: [PATCH v3 2/3] builtin/tag.c: add --trailer arg
On Mon, Apr 29, 2024 at 06:54:22PM +0000, John Passaro via GitGitGadget wrote:
Show 13 quoted lines
> From: John Passaro <john.a.passaro@gmail.com>
>
> git-tag currently supports interpreting trailers from an annotated tag
> message, using --list --format="%(trailers)". There is no ergonomic way
> to add trailers to an annotated tag message.
>
> In a previous patch, we refactored git-commit's implementation of its
> --trailer arg to the trailer.h API. Let's use that new function to teach
> git-tag the same --trailer argument, emulating as much of git-commit's
> behavior as much as possible.
>
> Signed-off-by: John Passaro <john.a.passaro@gmail.com>
> Helped-by: Patrick Steinhardt <ps@pks.im>
Same comment here regarding the order of trailers.
Other than that this commit looks good to me, thanks!
Patrick
Patrick Steinhardt <ps@pks.im>