Re: [PATCH v3 2/3] builtin/tag.c: add --trailer arg
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 30, 2024, 22:23 UTC
- Message-ID
- <xmqq4jbixzg6.fsf@gitster.g>
- In-Reply-To
- <CAJdN7Kggv-y8xRhdFanTyxa5wP-bG0omBPuETW6qijA67gn8oQ@mail.gmail.com>
John Passaro <john.a.passaro@gmail.com> writes:
> There's also project-specific trailers. For example, on my team, > we use "Deploy-Strategy: ..." to tell CICD what deployment routines to run. This > is pretty specific to us but worth calling out. Maybe could translate to a > documentation example with something like "<Project-specific-trailer>: foo"
The last one that uses placeholders for both trailer tag and value may be generic enough.
> However, in service of helping users find workarounds, shouldn't we tell them > --trailer may be the culprit? > >> Failed to read '%s'. Try again without --trailer (use -e or -F to add trailers manually).
I dunno.
If -m/-F that wrote the original using the open/write_or_die/close sequence succeeded, the "amend_file" thing successfully spawned "interpret-trailers --in-place" and got control back, yet we fail to read that message back, it does not smell like a failure with that "--trailer" option to me. A failure with "--trailer" that could be worked around would have been caught in "amend_file" thing, before the control reaches this point, no?