Re: [PATCH v5 1/3] builtin/commit: use ARGV macro to collect trailers
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 7, 2024, 17:06 UTC
- Message-ID
- <xmqqttj9pn5m.fsf@gitster.g>
- In-Reply-To
- <CAJdN7KhFtjWZfuGPsu2gWy7Dqth=PsVpA_d8923aNUqmQu8Phg@mail.gmail.com>
John Passaro <john.a.passaro@gmail.com> writes:
Show 19 quoted lines
>> From: John Passaro <john.a.passaro@gmail.com> >> >> Replace git-commit's callback for --trailer with the standard >> OPT_PASSTHRU_ARGV macro. The callback only adds its values to a strvec >> and sanity-checking that `unset` is always false; both of these are >> already implemented in the parse-option API. >> >> Signed-off-by: John Passaro <john.a.passaro@gmail.com> > > Looking over the patch series I notice that I left a grammar error in > this description, > if the patch makes it to the "next" branch I hope you can amend the > message first, > as follows: > > Replace git-commit's callback for --trailer with the standard > OPT_PASSTHRU_ARGV macro. The callback only adds its values to a strvec > and sanity-checks that `unset` is always false; both of these are > already implemented in the parse-option API.
Thanks for stopping me before the topic got merged to 'next'. Amended.