From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 30 Apr 2024 05:54:22 GMT
Subject: Re: [PATCH v3 2/3] builtin/tag.c: add --trailer arg
Message-ID: <ZjCHju27OJTm8V1k@tanuki>
In-Reply-To: <5b6239167b8d7c26f96e5c23d0d82b7a3a9b01fe.1714416865.git.gitgitgadget@gmail.com>

On Mon, Apr 29, 2024 at 06:54:22PM +0000, John Passaro via GitGitGadget wrote:
> From: John Passaro <john.a.passaro@gmail.com>
> 
> git-tag currently supports interpreting trailers from an annotated tag
> message, using --list --format="%(trailers)". There is no ergonomic way
> to add trailers to an annotated tag message.
> 
> In a previous patch, we refactored git-commit's implementation of its
> --trailer arg to the trailer.h API. Let's use that new function to teach
> git-tag the same --trailer argument, emulating as much of git-commit's
> behavior as much as possible.
> 
> Signed-off-by: John Passaro <john.a.passaro@gmail.com>
> Helped-by: Patrick Steinhardt <ps@pks.im>

Same comment here regarding the order of trailers.

Other than that this commit looks good to me, thanks!

Patrick