Re: [PATCH v4 1/3] builtin/commit.c: remove bespoke option callback
- From
Patrick Steinhardt <ps@pks.im>
- Date
- May 2, 2024, 06:27 UTC
- Message-ID
- <ZjMyRDDQ-uIx03H8@tanuki>
- In-Reply-To
- <ce047c58aa81cc5228ae9068d790585e012491c5.1714488111.git.gitgitgadget@gmail.com>
On Tue, Apr 30, 2024 at 02:41:49PM +0000, John Passaro via GitGitGadget wrote:
Show 6 quoted lines
> From: John Passaro <john.a.passaro@gmail.com> > > Replace git-commit's bespoke callback for --trailer with the standard > OPT_PASSTHRU_ARGV macro. The bespoke callback was only adding its values > to a strvec and sanity-checking that `unset` is always false; both of > these are already implemented in the parse-option API.
Nit: I feel like saying "bespoke" is a bit vague. I would have said something like the following:
builtin/commit: use ARGV option to collect custom trailers
In any case, I don't think this is a huge deal and not worth a reroll on its own.
Patrick