From: Josh Steadmon <steadmon@google.com>
Date: Fri, 23 Feb 2024 22:45:56 GMT
Subject: Re: [RFC PATCH v2 4/6] test-tool run-command testsuite: support unit tests
Message-ID: <ZdkgJMu3bddMmdbd@google.com>
In-Reply-To: <xmqqbk8s80hh.fsf@gitster.g>

On 2024.02.07 12:48, Junio C Hamano wrote:
> Josh Steadmon <steadmon@google.com> writes:
> 
> > Teach the testsuite runner in `test-tool run-command testsuite` how to
> > run unit tests: if TEST_SHELL_PATH is not set, assume that we're running
> > the programs directly from CWD, rather than defaulting to "sh" as an
> > interpreter.
> 
> Hmph.  It sounds more like "the run-command testsuite subcommand
> only runs programs in the current directory", not "assume" (which
> implies there is a way to override the assumption).  Not that the
> limitation would hurt us in any way, though.
> 
> > +	/*
> > +	 * If we run without a shell, we have to provide the relative path to
> > +	 * the executables.
> > +	 */
> 
> It sounds more like "If TEST_SHELL_PATH is not given, then we run
> them in the current directory.".

Reworded both of these in V3.