Re: [PATCH v3 00/11] reftable: small set of fixes

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 12, 2023, 03:45 UTC
Message-ID: <ZXfXQrNVReK9-RLP@tanuki>
In-Reply-To: <ZXduGvCJIa25eldZ@nand.local>

On Mon, Dec 11, 2023 at 03:16:26PM -0500, Taylor Blau wrote:

Show 19 quoted lines

> On Mon, Dec 11, 2023 at 10:07:25AM +0100, Patrick Steinhardt wrote:
> >  reftable/block.c          |  23 ++++----
> >  reftable/block.h          |   6 +++
> >  reftable/block_test.c     |   4 +-
> >  reftable/blocksource.c    |   2 +-
> >  reftable/iter.h           |   8 +--
> >  reftable/merged.c         |  31 +++++------
> >  reftable/merged.h         |   2 +
> >  reftable/reader.c         |   7 ++-
> >  reftable/readwrite_test.c |   6 +--
> >  reftable/stack.c          |  73 +++++++++++---------------
> >  reftable/stack_test.c     | 107 +++++++++++++++++++++++++++++++++++++-
> >  reftable/test_framework.h |  58 ++++++++++++---------
> >  12 files changed, 213 insertions(+), 114 deletions(-)
> >
> > Range-diff against v2:
> 
> I had one small question on the new version of the fourth patch, but
> otherwise this version LGTM.

Thanks for your review!

Patrick