Re: [PATCH v2 00/11] reftable: small set of fixes

From: Taylor Blau <me@ttaylorr.com>
Date: Dec 8, 2023, 22:26 UTC
Message-ID: <ZXOYMhlAdIP32l1O@nand.local>
In-Reply-To: <cover.1702047081.git.ps@pks.im>

On Fri, Dec 08, 2023 at 03:52:53PM +0100, Patrick Steinhardt wrote:

Show 13 quoted lines

>  reftable/block.c          |  23 ++++-----
>  reftable/block.h          |   6 +++
>  reftable/block_test.c     |   4 +-
>  reftable/blocksource.c    |   2 +-
>  reftable/iter.h           |   8 +--
>  reftable/merged.c         |  31 +++++------
>  reftable/merged.h         |   2 +
>  reftable/reader.c         |   7 ++-
>  reftable/readwrite_test.c |   6 +--
>  reftable/stack.c          |  73 +++++++++++---------------
>  reftable/stack_test.c     | 105 +++++++++++++++++++++++++++++++++++++-
>  reftable/test_framework.h |  58 +++++++++++----------
>  12 files changed, 211 insertions(+), 114 deletions(-)

This all looks good to me. I gave this a pretty careful read and added a couple of minor suggestions, but nothing that would indicate the need for a re-roll.

Thanks for working on this!

Thanks, Taylor