Re: [PATCH v2 11/11] reftable/block: reuse buffer to compute record keys

From: Han-Wen Nienhuys <hanwenn@gmail.com>
Date: Dec 21, 2023, 10:43 UTC
Message-ID: <CAOw_e7bQ+jxO2zhj32mDksq9uBKQfNt=wMNP5K6Oy1DqievCdg@mail.gmail.com>
In-Reply-To: <02b11f3a80608ba8748a0d0e2294f432e02464e5.1702047081.git.ps@pks.im>

On Fri, Dec 8, 2023 at 3:53 PM Patrick Steinhardt <ps@pks.im> wrote:

Show 6 quoted lines

> @@ -84,10 +84,12 @@ struct block_iter {
>
>         /* key for last entry we read. */
>         struct strbuf last_key;
> +       struct strbuf key;
>  };

it's slightly more efficient, but the new field has no essential meaning. If I encountered this code with the change you make here, I would probably refactor it in the opposite direction to increase code clarity.

I suspect that the gains are too small to be measurable, but if you are after small efficiency gains, you can have reftable_record_decode() consume the key to avoid copying overhead in record.c.

-- 
Han-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen