Re: [PATCH 5/8] reftable/stack: perform auto-compaction with transactional interface
- From
Han-Wen Nienhuys <hanwenn@gmail.com>
- Date
- Dec 21, 2023, 10:29 UTC
- Message-ID
- <CAOw_e7Yfdt_Wqm-9XDJknaN-iH=haP0R4K-S4c_E3EFDzvG5aA@mail.gmail.com>
- In-Reply-To
- <25522b042cdc5986972cc7b62e6b88be0569d3cb.1700549493.git.ps@pks.im>
On Tue, Nov 21, 2023 at 8:07 AM Patrick Steinhardt <ps@pks.im> wrote:
> Whenever updating references or reflog entries in the reftable stack, we > need to add a new table to the stack, thus growing the stack's length by
..
bug is correctly identified, but can't the fix remove the
if (!st->disable_auto_compact)
return reftable_stack_auto_compact(st);fragment from reftable_stack_add? reftable_addition_commit eventually calls reftable_addition_commit.
-- Han-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen