Re: [PATCH v3 00/11] reftable: small set of fixes

From: Taylor Blau <me@ttaylorr.com>
Date: Dec 11, 2023, 20:16 UTC
Message-ID: <ZXduGvCJIa25eldZ@nand.local>
In-Reply-To: <cover.1702285387.git.ps@pks.im>

On Mon, Dec 11, 2023 at 10:07:25AM +0100, Patrick Steinhardt wrote:

Show 15 quoted lines

>  reftable/block.c          |  23 ++++----
>  reftable/block.h          |   6 +++
>  reftable/block_test.c     |   4 +-
>  reftable/blocksource.c    |   2 +-
>  reftable/iter.h           |   8 +--
>  reftable/merged.c         |  31 +++++------
>  reftable/merged.h         |   2 +
>  reftable/reader.c         |   7 ++-
>  reftable/readwrite_test.c |   6 +--
>  reftable/stack.c          |  73 +++++++++++---------------
>  reftable/stack_test.c     | 107 +++++++++++++++++++++++++++++++++++++-
>  reftable/test_framework.h |  58 ++++++++++++---------
>  12 files changed, 213 insertions(+), 114 deletions(-)
>
> Range-diff against v2:

I had one small question on the new version of the fourth patch, but otherwise this version LGTM.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.