Re: [PATCH 2/8] builtin/repack.c: extract marking packs for deletion

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 7, 2023, 22:10 UTC
Message-ID: <ZPpKbKqJhBJcqyl3@nand.local>
In-Reply-To: <20230907075931.GB1260718@coredump.intra.peff.net>

On Thu, Sep 07, 2023 at 03:59:31AM -0400, Jeff King wrote:

Show 5 quoted lines

> There are really two "factor outs" here: we pull the code from
> cmd_repack() into a helper, and then the helper is also just a thin
> wrapper around its "_1" variant. That latter part isn't needed yet, but
> I can guess from your description that we'll eventually have the main
> function dispatch to the "_1" helper for lists.

Yeah... the "_1" variant looks ugly in isolation in this patch, but I think makes things cleaner in subsequent patches.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.