Re: [PATCH 0/8] repack: refactor pack snapshot-ing logic

From: Jeff King <peff@peff.net>
Date: Sep 7, 2023, 09:00 UTC
Message-ID: <20230907090031.GH1260718@coredump.intra.peff.net>
In-Reply-To: <cover.1693946195.git.me@ttaylorr.com>

On Tue, Sep 05, 2023 at 04:36:37PM -0400, Taylor Blau wrote:

Show 13 quoted lines

> This series refactors some of the 'git repack' internals to keep track
> of existing packs in a set of string lists stored in a single structure,
> instead of passing around multiple string lists to different functions
> throughout the various paths.
> 
> The result is that the interface around pack deletion, marking packs as
> redundant, and handling the set of pre-existing packs (both kept and
> non-kept) is significantly cleaner without introducing any functional
> changes.
> 
> I didn't mean to produce so much churn when I started writing these
> patches, which began as a simple effort to rename a couple of variables
> for more consistency.

These all look pretty reasonable to me. I wasn't quite sure about patch 7 and left some comments there, but all of the options are kind of ugly. Since it's limited to that one file, it may not be worth spending too much time or brain-power on trying to polish it further.

-Peff