Re: [PATCH v2 5/8] builtin/repack.c: extract `has_existing_non_kept_packs()`

From: Christian Couder <christian.couder@gmail.com>
Date: Sep 15, 2023, 10:02 UTC
Message-ID: <CAP8UFD043ut1h-3SW+YLoT1ZpSrRHBMi15w6rMmKqAp2UbV0Vw@mail.gmail.com>
In-Reply-To: <f4f7b4c08f682b5ebca474e8c1d51d31a2da76b8.1694632644.git.me@ttaylorr.com>

On Thu, Sep 14, 2023 at 12:13 AM Taylor Blau <me@ttaylorr.com> wrote:

Show 8 quoted lines

>
> When there is:
>
>   - at least one pre-existing packfile (which is not marked as kept),
>   - repacking with the `-d` flag, and
>   - not doing a cruft repack
>
> , then we pass a handful of additional options to the inner

Nit (not worth a reroll): I think the comma at the beginning of the above line would be better after "not doing a cruft repack".

Show 5 quoted lines

> `pack-objects` process, like `--unpack-unreachable`,
> `--keep-unreachable`, and `--pack-loose-unreachable`, in addition to
> marking any packs we just wrote for promisor remotes as kept in-core
> (with `--keep-pack`, as opposed to the presence of a ".keep" file on
> disk).