From: Taylor Blau <me@ttaylorr.com>
Date: Thu, 07 Sep 2023 22:10:52 GMT
Subject: Re: [PATCH 2/8] builtin/repack.c: extract marking packs for deletion
Message-ID: <ZPpKbKqJhBJcqyl3@nand.local>
In-Reply-To: <20230907075931.GB1260718@coredump.intra.peff.net>

On Thu, Sep 07, 2023 at 03:59:31AM -0400, Jeff King wrote:
> There are really two "factor outs" here: we pull the code from
> cmd_repack() into a helper, and then the helper is also just a thin
> wrapper around its "_1" variant. That latter part isn't needed yet, but
> I can guess from your description that we'll eventually have the main
> function dispatch to the "_1" helper for lists.

Yeah... the "_1" variant looks ugly in isolation in this patch, but I
think makes things cleaner in subsequent patches.

Thanks,
Taylor