Re: [PATCH v4 08/13] pack-bitmap.c: compute disk-usage with incremental MIDXs

From: Taylor Blau <me@ttaylorr.com>
Date: Mar 19, 2025, 00:30 UTC
Message-ID: <Z9oQPlUbeMI2IbV3@nand.local>
In-Reply-To: <20250318014139.GD1471939@coredump.intra.peff.net>

On Mon, Mar 17, 2025 at 09:41:39PM -0400, Jeff King wrote:

Show 10 quoted lines

> On Fri, Mar 14, 2025 at 04:18:44PM -0400, Taylor Blau wrote:
>
> > In a similar fashion as previous commits, use nth_midxed_pack() instead
> > of accessing the MIDX's ->packs array directly to support incremental
> > MIDXs.
>
> Probably not worth it to change it in an actual patch, but is it worth
> renaming midx->packs to something else to make sure we catch all of the
> spots that need to be considered? Or maybe you already did that, which
> is how you found all of these. :)

That's how I found them originally ;-).

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.