From: Taylor Blau <me@ttaylorr.com>
Date: Wed, 19 Mar 2025 00:30:54 GMT
Subject: Re: [PATCH v4 08/13] pack-bitmap.c: compute disk-usage with incremental MIDXs
Message-ID: <Z9oQPlUbeMI2IbV3@nand.local>
In-Reply-To: <20250318014139.GD1471939@coredump.intra.peff.net>

On Mon, Mar 17, 2025 at 09:41:39PM -0400, Jeff King wrote:
> On Fri, Mar 14, 2025 at 04:18:44PM -0400, Taylor Blau wrote:
>
> > In a similar fashion as previous commits, use nth_midxed_pack() instead
> > of accessing the MIDX's ->packs array directly to support incremental
> > MIDXs.
>
> Probably not worth it to change it in an actual patch, but is it worth
> renaming midx->packs to something else to make sure we catch all of the
> spots that need to be considered? Or maybe you already did that, which
> is how you found all of these. :)

That's how I found them originally ;-).

Thanks,
Taylor