Re: [PATCH v4 06/13] pack-bitmap.c: support bitmap pack-reuse with incremental MIDXs
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Mar 19, 2025, 00:17 UTC
- Message-ID
- <Z9oNF7+xuQKqYNPX@nand.local>
- In-Reply-To
- <CABPp-BH3h_XY-+K1uB5SWWKrr7UrN1JHpQX+fxgJ=pTaLwPZ9Q@mail.gmail.com>
On Mon, Mar 17, 2025 at 09:13:52PM -0700, Elijah Newren wrote:
Show 11 quoted lines
> On Fri, Mar 14, 2025 at 1:18 PM Taylor Blau <me@ttaylorr.com> wrote: > > > > In a similar fashion as previous commits in the first phase of > > incremental MIDXs, enumerate not just the packs in the current > > incremental MIDX layer, but previous ones as well. > > > > Likewise, in reuse_partial_packfile_from_bitmap(), when reusing only a > > single pack from a MIDX, use the oldest layer's preferred pack as it is > > likely to contain the most amount of reusable sections. > > "most amount" => "largest number" or "largest size" ?
Good call; between the two I prefer "largest number".
Thanks, Taylor