Re: [PATCH v4 13/13] midx: implement writing incremental MIDX bitmaps

> On Fri, Mar 14, 2025 at 1:19 PM Taylor Blau <me@ttaylorr.com> wrote:
>
> [...]
> > diff --git a/ewah/ewah_bitmap.c b/ewah/ewah_bitmap.c
> > index e92341b8fa..056c410efb 100644
> > --- a/ewah/ewah_bitmap.c
> > +++ b/ewah/ewah_bitmap.c
> > @@ -399,7 +399,7 @@ int ewah_or_iterator_next(eword_t *next, struct ewah_or_iterator *it)
> >         return ret;
> >  }
> >
> > -void ewah_or_iterator_free(struct ewah_or_iterator *it)
> > +void ewah_or_iterator_release(struct ewah_or_iterator *it)
> >  {
> >         free(it->its);
> >  }
> > diff --git a/ewah/ewok.h b/ewah/ewok.h
> > index 4b70641045..c29d354236 100644
> > --- a/ewah/ewok.h
> > +++ b/ewah/ewok.h
> > @@ -158,7 +158,7 @@ void ewah_or_iterator_init(struct ewah_or_iterator *it,
> >
> >  int ewah_or_iterator_next(eword_t *next, struct ewah_or_iterator *it);
> >
> > -void ewah_or_iterator_free(struct ewah_or_iterator *it);
> > +void ewah_or_iterator_release(struct ewah_or_iterator *it);
>
> Was the rename from these last two hunks squashed into the wrong
> patch?  Since you're not changing its definition, I'm assuming the
> updated name should have been applied to when it was introduced.