Re: [PATCH v4 08/13] pack-bitmap.c: compute disk-usage with incremental MIDXs

From: Jeff King <peff@peff.net>
Date: Mar 18, 2025, 01:41 UTC
Message-ID: <20250318014139.GD1471939@coredump.intra.peff.net>
In-Reply-To: <c1eefeae993f2c8778dd0ec9626f977dbb2011a2.1741983492.git.me@ttaylorr.com>

On Fri, Mar 14, 2025 at 04:18:44PM -0400, Taylor Blau wrote:

> In a similar fashion as previous commits, use nth_midxed_pack() instead
> of accessing the MIDX's ->packs array directly to support incremental
> MIDXs.

Probably not worth it to change it in an actual patch, but is it worth renaming midx->packs to something else to make sure we catch all of the spots that need to be considered? Or maybe you already did that, which is how you found all of these. :)

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.