git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t/unit-tests: convert unit-tests to use clar

From
Patrick Steinhardt <ps@pks.im>
Date
Jan 17, 2025, 13:36 UTC
Message-ID
<Z4pc5ItVQwTJNd--@pks.im>
In-Reply-To
<20250117122926.101749-1-kuforiji98@gmail.com>
On Fri, Jan 17, 2025 at 01:29:22PM +0100, Seyi Kuforiji wrote:
Show 8 quoted lines
> Hello,
> 
> This small patch series transitions the existing unit test files to the
> Clar testing framework. This change is part of our ongoing effort to
> standardize our testing approach and enhance maintainability.
> 
> changes in v3:
> - Some small fixes were made to the commit messages
Thanks, the series looks good to me now.
Show 22 quoted lines
> Range-diff against v2:
> 1:  00bb4d2880 ! 1:  f9e163a181 t/unit-tests: handle dashes in test suite filenames
>     @@ Metadata
>       ## Commit message ##
>          t/unit-tests: handle dashes in test suite filenames
>      
>     -    The script is designed to extract function signatures that match a
>     -    specific pattern derived from the unit test file's name.
>     -    `generate-clar-decls.sh` does not pick up dashes in filenames, which
>     -    prevents the scripts from being run.
>     +    "generate-clar-decls.sh" script is designed to extract function
>     +    signatures that match a specific pattern derived from the unit test
>     +    file's name. The script does not know to massage file names with dashes,
>     +    which will make it search for functions that look like, for example,
>     +    `test_mem-pool_*`. Having dashes in function names is not allowed
>     +    though, so these patterns won't ever match a legal function name.
>      
>          Adapt script to translate dashes (`-`) in test suite filenames to
>          underscores (`_`) to correctly extract the function signatures and run
> -:  ---------- > 2:  f46438f53e t/unit-tests: convert mem-pool test to use clar test framework
> -:  ---------- > 3:  f5cabebd3a t/unit-tests: adapt priority queue test to use clar test framework
> -:  ---------- > 4:  5323873612 t/unit-tests: convert reftable tree test to use clar test framework

The range-diff is still not correct :P Now it seems like you only passed the first commit of your v2 to it, instead of the tip of the v2 branch.

Patrick
Previous: Seyi Kuforiji
Message 24 of 24 in “t/unit-tests: convert unit-tests to use clar”
  1. 0/4 t/unit-tests: convert unit-tests to use clarSeyi Kuforiji, Jan 16, 2025
  2. 1/4 t/unit-tests: handle dashes in test suite filenamesSeyi Kuforiji, Jan 16, 2025
  3. Patrick SteinhardtJan 16, 2025
  4. 2/4 t/unit-tests: convert mem-pool test to use clar test frameworkSeyi Kuforiji, Jan 16, 2025
  5. Patrick SteinhardtJan 16, 2025
  6. Junio C HamanoJan 16, 2025
  7. 3/4 t/unit-tests: adapt priority queue test to use clar test frameworkSeyi Kuforiji, Jan 16, 2025
  8. Patrick SteinhardtJan 16, 2025
  9. 4/4 t/unit-tests: convert reftable tree test to use clar test frameworkSeyi Kuforiji, Jan 16, 2025
  10. 0/4 t/unit-tests: convert unit-tests to use clarSeyi Kuforiji, Jan 16, 2025
  11. 1/4 t/unit-tests: handle dashes in test suite filenamesSeyi Kuforiji, Jan 16, 2025
  12. Patrick SteinhardtJan 17, 2025
  13. 2/4 t/unit-tests: convert mem-pool test to use clar test frameworkSeyi Kuforiji, Jan 16, 2025
  14. 3/4 t/unit-tests: adapt priority queue test to use clar test frameworkSeyi Kuforiji, Jan 16, 2025
  15. 4/4 t/unit-tests: convert reftable tree test to use clar test frameworkSeyi Kuforiji, Jan 16, 2025
  16. Patrick SteinhardtJan 17, 2025
  17. t/unit-tests: convert unit-tests to use clarSeyi Kuforiji, Jan 17, 2025
  18. 1/4 t/unit-tests: handle dashes in test suite filenamesSeyi Kuforiji, Jan 17, 2025
  19. 2/4 t/unit-tests: convert mem-pool test to use clar test frameworkSeyi Kuforiji, Jan 17, 2025
  20. Karthik NayakJan 20, 2025
  21. 3/4 t/unit-tests: adapt priority queue test to use clar test frameworkSeyi Kuforiji, Jan 17, 2025
  22. Karthik NayakJan 20, 2025
  23. 4/4 t/unit-tests: convert reftable tree test to use clar test frameworkSeyi Kuforiji, Jan 17, 2025
  24. Patrick SteinhardtJan 17, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.