Re: [PATCH v2 1/4] t/unit-tests: handle dashes in test suite filenames

From: Patrick Steinhardt <ps@pks.im>
Date: Jan 17, 2025, 06:27 UTC
Message-ID: <Z4n4Qyt8qSBMVXUQ@pks.im>
In-Reply-To: <20250116161559.91038-2-kuforiji98@gmail.com>

On Thu, Jan 16, 2025 at 05:15:56PM +0100, Seyi Kuforiji wrote:

> The script is designed to extract function signatures that match a
> specific pattern derived from the unit test file's name.
> `generate-clar-decls.sh` does not pick up dashes in filenames, which
> prevents the scripts from being run.

As said in my first round, saying "scripts" here is misleading as the unit tests aren't scripts in the first place. How about:

    The "generate-clar-decls.sh" script is designed to extract function
    signatures that match a specific pattern derived from the unit test
    file's name. The script does not know to massage file names with
    dashes, which will make it search for functions that look like, for
    example, `test_mem-pool_*`. Having dashes in function names is not
    allowed though, so these patterns won't ever match a legal function
    name.

Patrick