git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/4] t/unit-tests: handle dashes in test suite filenames

From
Seyi Kuforiji <kuforiji98@gmail.com>
Date
Jan 17, 2025, 12:29 UTC
Message-ID
<20250117122926.101749-2-kuforiji98@gmail.com>
In-Reply-To
<20250117122926.101749-1-kuforiji98@gmail.com>

"generate-clar-decls.sh" script is designed to extract function signatures that match a specific pattern derived from the unit test file's name. The script does not know to massage file names with dashes, which will make it search for functions that look like, for example, `test_mem-pool_*`. Having dashes in function names is not allowed though, so these patterns won't ever match a legal function name.

Adapt script to translate dashes (`-`) in test suite filenames to underscores (`_`) to correctly extract the function signatures and run the corresponding tests. This will be used by subsequent commits which follows the same construct.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
---
 t/unit-tests/generate-clar-decls.sh | 1 +
 1 file changed, 1 insertion(+)
diff --git a/t/unit-tests/generate-clar-decls.sh b/t/unit-tests/generate-clar-decls.sh
index 3b315c64b3..abf6a2ea2a 100755
--- a/t/unit-tests/generate-clar-decls.sh
+++ b/t/unit-tests/generate-clar-decls.sh
@@ -14,6 +14,7 @@ do
 	suite_name=$(basename "$suite")
 	suite_name=${suite_name%.c}
 	suite_name=${suite_name#u-}
+	suite_name=$(echo "$suite_name" | tr '-' '_')
 	sed -ne "s/^\(void test_${suite_name}__[a-zA-Z_0-9][a-zA-Z_0-9]*(void)\)$/extern \1;/p" "$suite" ||
 	exit 1
 done >"$OUTPUT"
-- 
2.34.1
Previous: Seyi KuforijiNext: Seyi Kuforiji
Message 18 of 24 in “t/unit-tests: convert unit-tests to use clar”
  1. 0/4 t/unit-tests: convert unit-tests to use clarSeyi Kuforiji, Jan 16, 2025
  2. 1/4 t/unit-tests: handle dashes in test suite filenamesSeyi Kuforiji, Jan 16, 2025
  3. Patrick SteinhardtJan 16, 2025
  4. 2/4 t/unit-tests: convert mem-pool test to use clar test frameworkSeyi Kuforiji, Jan 16, 2025
  5. Patrick SteinhardtJan 16, 2025
  6. Junio C HamanoJan 16, 2025
  7. 3/4 t/unit-tests: adapt priority queue test to use clar test frameworkSeyi Kuforiji, Jan 16, 2025
  8. Patrick SteinhardtJan 16, 2025
  9. 4/4 t/unit-tests: convert reftable tree test to use clar test frameworkSeyi Kuforiji, Jan 16, 2025
  10. 0/4 t/unit-tests: convert unit-tests to use clarSeyi Kuforiji, Jan 16, 2025
  11. 1/4 t/unit-tests: handle dashes in test suite filenamesSeyi Kuforiji, Jan 16, 2025
  12. Patrick SteinhardtJan 17, 2025
  13. 2/4 t/unit-tests: convert mem-pool test to use clar test frameworkSeyi Kuforiji, Jan 16, 2025
  14. 3/4 t/unit-tests: adapt priority queue test to use clar test frameworkSeyi Kuforiji, Jan 16, 2025
  15. 4/4 t/unit-tests: convert reftable tree test to use clar test frameworkSeyi Kuforiji, Jan 16, 2025
  16. Patrick SteinhardtJan 17, 2025
  17. t/unit-tests: convert unit-tests to use clarSeyi Kuforiji, Jan 17, 2025
  18. 1/4 t/unit-tests: handle dashes in test suite filenamesSeyi Kuforiji, Jan 17, 2025
  19. 2/4 t/unit-tests: convert mem-pool test to use clar test frameworkSeyi Kuforiji, Jan 17, 2025
  20. Karthik NayakJan 20, 2025
  21. 3/4 t/unit-tests: adapt priority queue test to use clar test frameworkSeyi Kuforiji, Jan 17, 2025
  22. Karthik NayakJan 20, 2025
  23. 4/4 t/unit-tests: convert reftable tree test to use clar test frameworkSeyi Kuforiji, Jan 17, 2025
  24. Patrick SteinhardtJan 17, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.